Skip to content

Remove extra dash in --no-build argument in dotnet test invokation#1132

Merged
Sergio0694 merged 1 commit intoCommunityToolkit:mainfrom
echoix:patch-1
Nov 5, 2025
Merged

Remove extra dash in --no-build argument in dotnet test invokation#1132
Sergio0694 merged 1 commit intoCommunityToolkit:mainfrom
echoix:patch-1

Conversation

@echoix
Copy link
Contributor

@echoix echoix commented Nov 5, 2025 •
edited
Loading

New CI workflow fails because --no--build is passed to dotnet test. It should be --no-build

Closes #<ISSUE_NUMBER>

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

@echoix @Sergio0694
Remove extra dash in --no-build argument in dotnet test invokation
511e302 
New CI workflow fails because `--no--build` is passed to `dotnet test`. It should be `--no-build`
@echoix
Copy link
Contributor Author

echoix commented Nov 5, 2025

Remaining problems:

  • The other dotnet SDKs to target are not installed
  • The same result file name (.trx) is used and overwritten for all executions

@Sergio0694
Copy link
Member

Sergio0694 commented Nov 5, 2025

I'm fixing the first one in the other PR. I'll do one for the .trx too, unless you want to take that one 🙂

@Sergio0694 Sergio0694 merged commit 1768df1 into CommunityToolkit:main Nov 5, 2025
2 of 4 checks passed
@echoix
Copy link
Contributor Author

echoix commented Nov 5, 2025 •
edited
Loading

I'm not sure, and it will depend if you decide to install all SDKs in one matrix job (so using both dotnet-version AND global-json-file inputs, so it installs all from both versions), or you make them in separate matrix jobs, listing each as a matrix strategy variable. Go ahead and do the second one after finished with the first

@echoix echoix deleted the patch-1 branch November 5, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sergio0694 Sergio0694 Sergio0694 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@echoix @Sergio0694